Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add other session providers #5963

Merged
merged 6 commits into from
Feb 5, 2019
Merged

add other session providers #5963

merged 6 commits into from
Feb 5, 2019

Conversation

techknowlogick
Copy link
Member

Fix #3717

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 4, 2019
@techknowlogick techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 4, 2019
@codecov-io
Copy link

codecov-io commented Feb 4, 2019 •
edited
Loading

Codecov Report

Merging #5963 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5963      +/-   ##
=========================================
- Coverage    38.7%   38.7%   -0.01%     
=========================================
  Files         330     330              
  Lines       48642   48642              
=========================================
- Hits        18827   18825       -2     
- Misses      27088   27090       +2     
  Partials     2727    2727
Impacted Files Coverage Δ
modules/setting/setting.go 51.71% <100%> (ø) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4bada...271c4c3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 4, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2019
@techknowlogick
Copy link
Member Author

make LG-TM work

@techknowlogick techknowlogick merged commit 9de871a into go-gitea:master Feb 5, 2019
@techknowlogick techknowlogick deleted the issue-3717 branch February 5, 2019 16:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

no session provider 'mysql'
5 participants
@techknowlogick @codecov-io @lafriks @zeripath @GiteaBot